[Architecture] Mechanism of Adding UI Permissions needs to change
Afkham Azeez
azeez at wso2.com
Mon Feb 8 03:38:28 EST 2010
The terminology is wrong. Why have you called this UIPermissions? Also, is
it possible to write a schema for this?
<componentBuilders>
<componentBuilder>
<id>UIPermissions</id>
<class>org.wso2.carbon.user.mgt.component.xml.UIPermissionsBuilder</class>
</componentBuilder>
</componentBuilders>
<UIPermissions>
<UIPermission>
<DisplayName>Monitor</DisplayName>
<ResourceId>/permission/admin/monitor</ResourceId>
</UIPermission>
</UIPermissions>
Does UIPermissions value in the id element point to the UIPermissions element?
Azeez
On Mon, Feb 8, 2010 at 12:19 AM, Dimuthu Leelarathne <dimuthul at wso2.com>wrote:
> Hi all,
>
> This is implemented. Please find a sample component.xml here[1].
>
> Thanks,
> DimuthuL
>
> [1]
> https://svn.wso2.org/repos/wso2/trunk/carbon/components/system-statistics/org.wso2.carbon.statistics/src/main/resources/META-INF/component.xml
>
>
> On Fri, Feb 5, 2010 at 4:50 PM, Dimuthu Leelarathne <dimuthul at wso2.com>wrote:
>
>>
>>
>> On Fri, Feb 5, 2010 at 4:25 PM, Ruwan Linton <ruwan at wso2.com> wrote:
>>
>>> Dimuthu Leelarathne wrote:
>>> >
>>> >
>>> > On Fri, Feb 5, 2010 at 4:02 PM, Ruwan Linton <ruwan at wso2.com
>>> > <mailto:ruwan at wso2.com>> wrote:
>>> >
>>> > Dimuthu Leelarathne wrote:
>>> > > Hi,
>>> > >
>>> > > +1 on the idea to remove boiler plate code.
>>> > >
>>> > > -1 on adding the permission on component.xml. The permissions are
>>> > > added by the BE bundle of the relevant UI bundle. My idea is that
>>> it
>>> > > should be an annotation.
>>> > Why do you think that it has to be an annotation, but not a
>>> > parameter in
>>> > the component.xml, here the component.xml means the component.xml
>>> > of the
>>> > BE bundle not that of the UI bundle..
>>> >
>>> >
>>> > I was referring to the component.xml of the FE bundle. +1 for the
>>> > component.xml of the BE bundle.
>>> Cool, can you please fix the core and let us know the parameter that we
>>> need to put in the component.xml so that we can fix this across all the
>>> components? We need this to be done ASAP, because we are planning to
>>> give a build on next Wednesday.
>>>
>>>
>> Sure thing...
>>
>> Thanks,
>> DimuthuL
>>
>>
>>> Thanks,
>>> Ruwan
>>> >
>>> > Thank you,
>>> > DimuthuL
>>> >
>>> >
>>> >
>>> > Thanks,
>>> > Ruwan
>>> > >
>>> > > Thank you,
>>> > > DimuthuL
>>> > >
>>> > > On Fri, Feb 5, 2010 at 3:04 PM, Afkham Azeez <azeez at wso2.com
>>> > <mailto:azeez at wso2.com>
>>> > > <mailto:azeez at wso2.com <mailto:azeez at wso2.com>>> wrote:
>>> > >
>>> > > DimuthuL? :)
>>> > >
>>> > > Azeez
>>> > >
>>> > >
>>> > > On Fri, Feb 5, 2010 at 2:58 PM, Ruwan Linton <ruwan at wso2.com
>>> > <mailto:ruwan at wso2.com>
>>> > > <mailto:ruwan at wso2.com <mailto:ruwan at wso2.com>>> wrote:
>>> > >
>>> > > Who is going to own this?
>>> > >
>>> > > We need this done for the 3.0 release meaning that it
>>> > has to be
>>> > > completed before Wednesday, if some one can implement
>>> > the core
>>> > > logic, we
>>> > > can get component owners to fix there own components,
>>> > like in
>>> > > how we did
>>> > > with registry separation and so forth.
>>> > >
>>> > > Thanks,
>>> > > Ruwan
>>> > >
>>> > > Afkham Azeez wrote:
>>> > > > +1. This is why we need to have code reviews once a
>>> > week, and
>>> > > > religiously adhere to that practice. This week's code
>>> > review
>>> > > > attendance was extremely poor. Only about 15 people
>>> > > participated. Code
>>> > > > reviewing is a learning experience, and attendance is
>>> not
>>> > > optional.
>>> > > > Even interns (specially interns) should also
>>> participate.
>>> > > Perhaps from
>>> > > > next week, if the attendance is low, we need to send
>>> the
>>> > > names of the
>>> > > > attendees to the mailing list, along with the code
>>> review
>>> > > notes :)
>>> > > >
>>> > > > Azeez
>>> > > >
>>> > > > On Thu, Feb 4, 2010 at 5:35 PM, Senaka Fernando
>>> > > <senaka at wso2.com <mailto:senaka at wso2.com>
>>> > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>>
>>> > > > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>
>>> > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>>>> wrote:
>>> > > >
>>> > > > Hi all,
>>> > > >
>>> > > > As per code review discussion, the UI Permissions
>>> are
>>> > > added in a
>>> > > > very wrong way at the moment. These are added
>>> through
>>> > > boiler plate
>>> > > > java code in each BE component. This should
>>> > ideally be a
>>> > > > configuration that is added on the component.xml
>>> file.
>>> > > >
>>> > > > Thanks,
>>> > > > Senaka.
>>> > > >
>>> > > > --
>>> > > > Senaka Fernando
>>> > > > Software Engineer
>>> > > > WSO2 Inc.
>>> > > > E-mail: senaka at wso2.com <mailto:senaka at wso2.com>
>>> > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>>
>>> > > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>
>>> > <mailto:senaka at wso2.com <mailto:senaka at wso2.com>>>; Mobile: +94
>>> 77
>>> > > > 322 1818
>>> > > >
>>> > > > http://www.wso2.com/ - "Lean . Enterprise .
>>> > Middleware"
>>> > > >
>>> > > > _______________________________________________
>>> > > > Architecture mailing list
>>> > > > Architecture at wso2.org
>>> > <mailto:Architecture at wso2.org> <mailto:Architecture at wso2.org
>>> > <mailto:Architecture at wso2.org>>
>>> > > <mailto:Architecture at wso2.org
>>> > <mailto:Architecture at wso2.org> <mailto:Architecture at wso2.org
>>> > <mailto:Architecture at wso2.org>>>
>>> > > >
>>> > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> > > >
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > --
>>> > > > Afkham Azeez
>>> > > > azeez at wso2.com <mailto:azeez at wso2.com>
>>> > <mailto:azeez at wso2.com <mailto:azeez at wso2.com>>
>>> > > <mailto:azeez at wso2.com <mailto:azeez at wso2.com>
>>> > <mailto:azeez at wso2.com <mailto:azeez at wso2.com>>>
>>> > > > WSO2 Inc. http://wso2.com
>>> > > > Blog: http://afkham.org
>>> > > >
>>> > >
>>> >
>>> ------------------------------------------------------------------------
>>> > > >
>>> > > > _______________________________________________
>>> > > > Architecture mailing list
>>> > > > Architecture at wso2.org <mailto:Architecture at wso2.org>
>>> > <mailto:Architecture at wso2.org <mailto:Architecture at wso2.org>>
>>> > > >
>>> > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> > > >
>>> > >
>>> > >
>>> > > --
>>> > > Ruwan Linton
>>> > > Technical Lead & Product Manager; WSO2 ESB;
>>> > http://wso2.org/esb
>>> > > WSO2 <http://wso2.org/esbWSO2> Inc.; http://wso2.org
>>> > > email: ruwan at wso2.com <mailto:ruwan at wso2.com>
>>> > <mailto:ruwan at wso2.com <mailto:ruwan at wso2.com>>; cell: +94 77
>>> > > 341 3097
>>> > > blog: http://blog.ruwan.org
>>> > >
>>> > > Lean . Enterprise . Middleware
>>> > >
>>> > >
>>> > > _______________________________________________
>>> > > Architecture mailing list
>>> > > Architecture at wso2.org <mailto:Architecture at wso2.org>
>>> > <mailto:Architecture at wso2.org <mailto:Architecture at wso2.org>>
>>> > >
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> > >
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > --
>>> > > Afkham Azeez
>>> > > azeez at wso2.com <mailto:azeez at wso2.com>
>>> > <mailto:azeez at wso2.com <mailto:azeez at wso2.com>>
>>> > > WSO2 Inc. http://wso2.com
>>> > > Blog: http://afkham.org
>>> > >
>>> > > _______________________________________________
>>> > > Architecture mailing list
>>> > > Architecture at wso2.org <mailto:Architecture at wso2.org>
>>> > <mailto:Architecture at wso2.org <mailto:Architecture at wso2.org>>
>>> > > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> > >
>>> > >
>>> > >
>>> >
>>> ------------------------------------------------------------------------
>>> > >
>>> > > _______________________________________________
>>> > > Architecture mailing list
>>> > > Architecture at wso2.org <mailto:Architecture at wso2.org>
>>> > > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> > >
>>> >
>>> >
>>> > --
>>> > Ruwan Linton
>>> > Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>>> > WSO2 <http://wso2.org/esb%0AWSO2> Inc.; http://wso2.org
>>> > email: ruwan at wso2.com <mailto:ruwan at wso2.com>; cell: +94 77 341
>>> 3097
>>> > blog: http://blog.ruwan.org
>>> >
>>> > Lean . Enterprise . Middleware
>>> >
>>> >
>>> > _______________________________________________
>>> > Architecture mailing list
>>> > Architecture at wso2.org <mailto:Architecture at wso2.org>
>>> > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> >
>>> >
>>> >
>>> ------------------------------------------------------------------------
>>> >
>>> > _______________________________________________
>>> > Architecture mailing list
>>> > Architecture at wso2.org
>>> > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>> >
>>>
>>>
>>> --
>>> Ruwan Linton
>>> Technical Lead & Product Manager; WSO2 ESB; http://wso2.org/esb
>>> WSO2 <http://wso2.org/esb%0AWSO2> Inc.; http://wso2.org
>>> email: ruwan at wso2.com; cell: +94 77 341 3097
>>> blog: http://blog.ruwan.org
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>>> _______________________________________________
>>> Architecture mailing list
>>> Architecture at wso2.org
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>
>>
>>
>
> _______________________________________________
> Architecture mailing list
> Architecture at wso2.org
> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>
>
--
--
Afkham Azeez
azeez at wso2.com
WSO2 Inc. http://wso2.com
Blog: http://afkham.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.wso2.org/pipermail/architecture/attachments/20100208/f072182a/attachment.html>
More information about the Architecture
mailing list