[Carbon-dev] Adding a new method to the AbstractAdmin - getGovernanceSystemRegistry()

[Thilina Buddhika]

Hi Devs,

In the current implementation of AbstractAdmin, following methods are
available for obtaining different registry instances.

For the config registry,
   - getConfigUserRegistry()
   - getConfigSystemRegistry()

For the local repo,
  - getLocalRepo()

For the governance registry,
  - getGovernanceRegistry()

getGovernanceRegistry() returns a governance user registry instance. But
there are situations where we need to have the governance system registry
instead of the governance user registry.

For example, we are storing the key stores in the governance registry. But
for that we should use governance system registry, not the user registry.
Because any user who has corresponding permissions should be able to
add/edit these key stores. Currently we have used governance user registry
for this and it has caused bugs like
CARBON-8840<https://wso2.org/jira/browse/CARBON-8840>
.

So we are planning to add a new method to get the governance system registry
from the AbstractAdmin. So it will be named as getGovernanceSystemRegistry().
To be consistent with the rest if the API, the existing
getGovernanceRegistry() should be renamed as getGovernanceUserRegistry().
But since we cannot refactor it at the moment, we can add a new method
getGovernanceUserRegistry
which returns the governance user registry and mark the
getGovernanceRegistry() as
deprecated.

WDYT ?

Thanks,
Thilina

-- 
Thilina Buddhika
Senior Software Engineer
WSO2 Inc. ; http://wso2.com
lean . enterprise . middleware

phone : +94 77 44 88 727
blog : http://blog.thilinamb.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.wso2.org/pipermail/carbon-dev/attachments/20110315/655cb703/attachment.htm>